Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anishere_Mariam: Outreachy_Contributions #21

Open
AnishereMariam opened this issue Mar 15, 2023 · 10 comments
Open

Anishere_Mariam: Outreachy_Contributions #21

AnishereMariam opened this issue Mar 15, 2023 · 10 comments

Comments

@AnishereMariam
Copy link

Task #6: Explore NYC taxi trips data set

I performed an Exploratory Data Analysis using the Yellow_Trip_Records for November 2022 using the pandas, and Bokeh libraries for data preparation and visualization, respectively.

My submission can be found on this GitHub Gist Page

I appreciate any reviews and comment on it. Thank you
cc @pavithraes, @bryevdv

@AnishereMariam
Copy link
Author

AnishereMariam commented Mar 15, 2023

Task #4 Set up a local environment for Bokeh

I completed this task.

Submission:

bkdev env
bkdev works

cc @pavithraes, @bryevdv

@AnishereMariam
Copy link
Author

AnishereMariam commented Mar 15, 2023

Project #2 Create a blog post series: "Fundamentals of Data Visualizations in Bokeh."

I created a GitHub profile to host my blog post on the topic and continuously populated it with details and visualization with bokeh.

Submission: Blog Post

Reference: Fundamentals of Data Visualization by Claus O. Wilke

cc @pavithraes, @bryevdv

@AnishereMariam
Copy link
Author

AnishereMariam commented Mar 15, 2023

Task #5 Work on "Add metadata to standalone examples", examples/plotting.

I added metadata to cutomjs_expr.py and filtering.py and created a pull request (PR #12979) to finalize the changes.

Submission: bokeh/bokeh#12979

cc @pavithraes, @bryevdv

@AnishereMariam
Copy link
Author

AnishereMariam commented Mar 15, 2023

Task #7 Update a Bokeh example plot.

I updated the palette of linear_cmap.py.
Submission: bokeh/bokeh#12980
cmap

cc @pavithraes, @bryevdv

@pavithraes
Copy link
Member

@AnishereMariam Thanks for sharing! I'd like to acknowledge that this satisfies the microtasks, and we'll share more detailed feedback soon. :)

@AnishereMariam
Copy link
Author

AnishereMariam commented Mar 17, 2023

Project #3: Improve the accessibility of Bokeh's Gallery examples.

Submission;
Accessibility improvement via metadata addition; PR #12979

@bryevdv
Copy link
Member

bryevdv commented Mar 19, 2023

👍 just noting that you have satisified the metadata micro-task

@AnishereMariam
Copy link
Author

@pavithraes, @bryevdv, thank you guys so much. Contributing here is just wonderful.

@pavithraes
Copy link
Member

@AnishereMariam Your notebook for exploring the NYC taxi data looks great, I'd encourage you to include https://anisheremariam.github.io/Bokeh_Outreachy/ in your final application!

Some additional thoughts:

  • I think you've written well-structured code with appropriate and useful comments.
  • I also liked the theme and your color choices throughout.
  • Your first two plots are nice and complete, I think the rod plot and multi plot can also benefit from a plot title and axes labels.
  • The markdown cells in your Jupyter notebook all have heading elements. It's usually a good practice to follow the heading hierarchy in markdown, so I would suggest some quick updates to improve the structure there. For example, "There are 3.75% Null values in only five columns, hence, I am dropping the NULL Values" can be normal text, and you can add new section headings where relevant.
  • If you have the time and wish to, I'll encourage you to try out some interactive elements of Bokeh as well -- this is not mandatory, and you can absolutely submit your current work. :)
  • I appreciate you taking the time mapping the actual payment types to their numeric values in your final bar plot!

Let me know if you need any clarifications or another review, but I think you're in a good position to submit your work!

@AnishereMariam
Copy link
Author

Thank you @pavithraes, I appreciate the positive feedback. I want the series to be really helpful for bokeh beginners so I noted your suggestions and I will improve the blog post. Thank you again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants