Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First Contribution #8

Closed
wants to merge 1 commit into from
Closed

Conversation

AnishereMariam
Copy link

Added two visualizations using the Bokeh Libraries

Added two visualizations using the Bokeh Libraries
@bryevdv
Copy link
Member

bryevdv commented Mar 14, 2023

Hi @AnishereMariam thanks for the PR, this satisfies the micro task. You have demonstrated familiarity with the Bokeh and PandasAPIS. I appreciate the legend on the second plot My main comment would be that the notebooks and plots could use more "story", e.g. the notebooks could benefit from some narrative markdown text explaining what is to be looked at, why it is interesting, any conclusions the plots supports, etc.

cc @pavithraes for additional comments

@AnishereMariam
Copy link
Author

@bryevdv, thank you so much. Your comment and observations are duly noted. I have created a blog series that includes the detailed explanation of each visualization. View my blog post HERE.

cc @pavithraes

@pavithraes
Copy link
Member

@AnishereMariam I think your issue #21 (which includes your blog + gist with more plots) supersedes your work in this PR. If you agree, please feel free to close this PR and we can keep discussions on #21. :)

@AnishereMariam
Copy link
Author

@pavithraes, yes I totally agree with you. #21 is the parent of my contributions. I will close this now as suggested. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants