Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetics including address payable #3

Closed
bokkypoobah opened this issue Mar 13, 2019 · 0 comments
Closed

Cosmetics including address payable #3

bokkypoobah opened this issue Mar 13, 2019 · 0 comments

Comments

@bokkypoobah
Copy link
Owner

@pertsev provided some cosmetic suggestions.

I will not be marking owner and newOwner as payable, as suggested, as the payable prevents an address variable from accidentally being used in a .transfer(...).

I will be leaving the address(uint160(owner)).transfer(...) casting in place, as this explicitly marks the statement where the transfer is made. For me, at least

bokkypoobah added a commit that referenced this issue Mar 13, 2019
bokkypoobah added a commit that referenced this issue Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant