New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also test 0.business_days/hours.before #166

Merged

bokmann merged 1 commit into bokmann:develop from jaredbeck:also_test_zero_days_before

Jun 30, 2017

Contributor

jaredbeck commented Jun 28, 2017

29f611d introduced tests for after. (Thanks, Mateusz)
Here, we test before.


          Also test 0.business_days/hours.before

cdb82e4

29f611d introduced tests for `after`. (Thanks, Mateusz)
Here, we test `before`.

Contributor Author

jaredbeck commented Jun 28, 2017

At first, I was thinking "why the heck would you use Time.parse in the tests" but it does make them easier to read, doesn't it? I like it.

bokmann merged commit 6315bc8 into bokmann:develop

jaredbeck deleted the also_test_zero_days_before branch

June 30, 2017 15:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet