-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow passing holidays with each invocation. #180
Allow passing holidays with each invocation. #180
Conversation
Wow... I like this solution to a problem I've had (calculating backwards after snow days have happened), and it was less impactful that I would have considered. It has a merge conflict with another pull I just merged, but if you resolve that it'll go into the next version! Thanks for the first-time commit! Don't forget to add yourself as a contributor to the readme! |
We recently had a problem with a local holiday in our region that does not exist in other regions of Germany. It would be solvable with Inspired by this I thought of an direct integration of the |
Do you think this could be merged, please? |
@Laykou This PR has merge conflicts that would need to be resolved first. |
@mstate Would you be willing to resolve the conflicts, please? |
I took a stab at resolving the conflicts in #217 |
Modified code, test and documentation to allow passing a holiday or array of holidays with each invocation. This is particularly useful when dealing with potentially different regional holidays during each invocations.