Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 Fix warnings #202

Merged
merged 4 commits into from
Feb 24, 2021
Merged

🚨 Fix warnings #202

merged 4 commits into from
Feb 24, 2021

Conversation

rmm5t
Copy link
Collaborator

@rmm5t rmm5t commented Feb 18, 2021

What does it do?

  • Fix warnings for ambiguous - operator usage
  • Fix minitest deprecation warning
  • Remove duplicate definitions of config properties

What else do you need to know?

business_time was generating syntax and deprecation warnings.

.../business_time/test/test_business_days.rb:240: warning: ambiguous first argument; put parentheses or a space even after `-' operator
.../business_time/test/test_business_days.rb:256: warning: ambiguous first argument; put parentheses or a space even after `-' operator
.../business_time/test/test_business_days.rb:257: warning: ambiguous first argument; put parentheses or a space even after `-' operator
.../business_time/lib/business_time/config.rb:121: warning: method redefined; discarding old end_of_workday
.../business_time/lib/business_time/config.rb:71: warning: previous definition of end_of_workday was here
.../business_time/lib/business_time/config.rb:130: warning: method redefined; discarding old beginning_of_workday
.../business_time/lib/business_time/config.rb:71: warning: previous definition of beginning_of_workday was here
.../business_time/lib/business_time/config.rb:139: warning: method redefined; discarding old work_week=
.../business_time/lib/business_time/config.rb:77: warning: previous definition of work_week= was here
.../business_time/test/test_business_hours.rb:223: warning: ambiguous first argument; put parentheses or a space even after `-' operator
.../business_time/test/test_business_hours.rb:289: warning: ambiguous first argument; put parentheses or a space even after `-' operator
.../business_time/test/test_business_hours.rb:292: warning: ambiguous first argument; put parentheses or a space even after `-' operator
.../business_time/test/test_business_hours.rb:301: warning: ambiguous first argument; put parentheses or a space even after `-' operator
.../business_time/test/test_business_hours.rb:311: warning: ambiguous first argument; put parentheses or a space even after `-' operator
.../business_time/test/test_business_hours.rb:312: warning: ambiguous first argument; put parentheses or a space even after `-' operator
.../business_time/test/test_business_hours.rb:314: warning: ambiguous first argument; put parentheses or a space even after `-' operator
.../business_time/test/test_business_hours_eastern.rb:119: warning: ambiguous first argument; put parentheses or a space even after `-' operator
.../business_time/test/test_business_hours_utc.rb:117: warning: ambiguous first argument; put parentheses or a space even after `-' operator

@boomer196
Copy link

Thank you! 👍 . Hoping this gets merged.

@bokmann bokmann merged commit 1178a43 into bokmann:develop Feb 24, 2021
@rmm5t rmm5t deleted the fix-warnings branch February 24, 2021 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants