Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add font-display: block to font face declaration #207

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PikachuEXE
Copy link

Lighthouse is warning about it and
some browsers would use incorrect behaviour (swap) if auto or nothing provided
Issue on FA:
FortAwesome/Font-Awesome#16077

Change already scheduled for FA 5.12.2
FortAwesome/Font-Awesome#16077 (comment)

Lighthouse is warning about it and
some browsers would use incorrect behaviour (swap) if `auto` or nothing provided
Issue on FA:
FortAwesome/Font-Awesome#16077

Change already scheduled for FA 5.12.2
FortAwesome/Font-Awesome#16077 (comment)
@firedev
Copy link

firedev commented Sep 26, 2021

That's interesting. I proposed swap, but yeah, maybe block is better.

@ABrisset
Copy link

Hi,
I was about to create a new pull request about this subject also.
I suggest "font-display: swap", as it is recommended by Google here https://web.dev/font-display/?utm_source=lighthouse&utm_medium=devtools#how-to-avoid-showing-invisible-text
Problem with "font-display: block" is that it may delay FCP.
What do you think ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants