Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

ENH: Update NCBITaxonomyDirFmt to accomodate data-version file #72

Closed
Tracked by #107 ...
Sann5 opened this issue Jan 16, 2024 · 2 comments
Closed
Tracked by #107 ...

ENH: Update NCBITaxonomyDirFmt to accomodate data-version file #72

Sann5 opened this issue Jan 16, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Sann5
Copy link
Contributor

Sann5 commented Jan 16, 2024

  • An fetch-ncbi-taxonomy-data action is planned (ENH: Fetch NCBI Taxonomy Data (input to build_custom_diamond_db action) q2-moshpit#107)
  • This will download data from two different sources. Consequently, there is a need to add version information to the resulting artifact.
  • This information will be written to an additional file within the artifact, provisionally version.tsv.
  • Consequently, there is a need to modify the code in NCBITaxonomyDirFmt to accommodate this extra file.
  • Validation for the extra file should also be implemented.
  • Test suit should be adjusted/expanded accordingly.
@Sann5 Sann5 added the enhancement New feature or request label Jan 16, 2024
@Sann5 Sann5 self-assigned this Jan 16, 2024
@Sann5 Sann5 changed the title ENH: Add date information to NCBITaxonomyDirFmt ENH: Update NCBITaxonomyDirFmt to accomodate data-version file Jan 16, 2024
@misialq
Copy link
Contributor

misialq commented Jan 29, 2024

Hey @Sann5, do we still need this or can it be closed?

@Sann5
Copy link
Contributor Author

Sann5 commented Jan 30, 2024

@misialq pps I closed the PR but not the issue. Sorry. I close it now.

@Sann5 Sann5 closed this as completed Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants