This repository has been archived by the owner on May 21, 2024. It is now read-only.
IMP: add feature_dict method to MAGSequencesDirFmt
#70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinvwood
changed the title
MAGSequencesDirFmtfeature-dict method to MAGSequencesDirFmt
colinvwood
changed the title
feature-dict method to MAGSequencesDirFmtfeature_dict method to MAGSequencesDirFmt
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
==========================================
+ Coverage 96.35% 96.42% +0.07%
==========================================
Files 42 42
Lines 1371 1400 +29
==========================================
+ Hits 1321 1350 +29
Misses 50 50 ☔ View full report in Codecov by Sentry. |
misialq
approved these changes
Dec 7, 2023
misialq
pushed a commit
to misialq/q2-types-genomics
that referenced
this pull request
Jan 15, 2024
* add feature_dict to MAGSequencesDirFmt * make equivalent method in ContigSequencesDirFmt comparable * dummy non mag for coverage
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
feature_dictmethod to theMAGSequencesDirFmtformat. Essentially mirrors the changes made in #57 for theContigSequencesDirFmtformat.These two methods are very similar, so it might be worthwhile to centralize them in the future.
Needed for #56.