fix: generated JSX namespace not working with React 19 #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed solution
This PR fixed the issue that make the package not usable with React 19 and Typescript. The generated typing use JSX.Element namespace that is now removed from typing of React 19. The recommended way is to use JSX.React.Element. Since this package doesn't use JSX.Element directly, simply upgrade the @types/react package will fix the generated code.
Tradeoffs
Testing Done
Playwright test all pass, obviously since this is only typing change.
Generated typing files now use the correct JSX namespace.