Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

374159-Need to upgrade embedding sample to .NET core to 8.0 #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SuryaVijayakumarSF4316
Copy link
Contributor

@SuryaVijayakumarSF4316 SuryaVijayakumarSF4316 commented Jul 9, 2024

General

Types of changes Improvements
Task Description Task 374159: Support - Need to upgrade embedding sample to .NET core to 8.0
Solution description Upgraded to latest node version
Is Breaking issue? No breaking issue.
UX Design Link Not applicable
Areas affected and ensured No areas are affected.
Is a change log required? No
If required, what is the change log content? List the change logs.

Output screenshots

Before changes:
image

After changes:
image

Check list

Please confirm all item in this checklist before sharing the PR with reviewer

  • Self reviewed my PR and confirmed no unwanted changes included
  • Get the techincal review for newly added content
  • Get the content review for newly added content
  • Get the UX review for final implementation if changes related to UI
  • Ensured my changes in all browser Chrome, Firefox, Edge with different zoom-in and zoom-out
  • Ensured my changes in different system resolutions are 100%, 125% and 150%
  • Ensured my changes in browser window resizing from mobile to desktop vice versa
  • Ensured my changes in mobile resolution mode
  • Shown the demo to reviewer
  • Whether my changes are ensured in staging sites if applicable
  • Created documentation task or included details in existing tasks, whether my changes have new or revamp API's in Embedded SDK
  • Ensured the code compilation success in My PR

Copy link
Collaborator

@MadeshGiri MadeshGiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes are fine saw the demo sample is running properly without any issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants