Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move form selector to individual method #36

Merged
merged 2 commits into from
Apr 3, 2019

Conversation

tdgroot
Copy link
Contributor

@tdgroot tdgroot commented Apr 2, 2019

In my case I wanted to create a mixin for getting the form in the validator. Moving that part to a separate method makes it possible, while increasing readability as well.

@boldsidney boldsidney merged commit 14fdce2 into boldcommerce:master Apr 3, 2019
@boldsidney
Copy link
Contributor

Thanks for the code improvement. I've tagged a new release with your changes.

@tdgroot
Copy link
Contributor Author

tdgroot commented Apr 5, 2019

@boldsidney thank you for processing it so quickly!

@tdgroot tdgroot deleted the get-form-method branch September 15, 2020 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants