Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace concurrent-ruby with MonitorMixin #114

Merged
merged 1 commit into from
Oct 23, 2017

Conversation

bschaeffer
Copy link
Contributor

@bschaeffer bschaeffer commented Sep 5, 2017

concurrent-ruby isn't needed just to do thread safe hashes. Prompted by this memory profile where including the gem is adding almost 6MB at startup:

stoplight: 5.8203 MiB
    stoplight/data_store/memory: 5.293 MiB
      concurrent: 5.2383 MiB
        concurrent/executors: 1.3906 MiB
          concurrent/executor/timer_set: 0.6953 MiB
            concurrent/scheduled_task: 0.4844 MiB (Also required by: concurrent, concurrent/timer_task)
              concurrent/ivar: 0.3047 MiB (Also required by: concurrent/async, concurrent/future, and 2 others)
        concurrent/configuration: 1.3203 MiB (Also required by: concurrent/scheduled_task, concurrent/options, and 2 others)
          concurrent/delay: 0.8789 MiB (Also required by: concurrent/utility/processor_counter, concurrent)
            concurrent/concern/obligation: 0.7031 MiB (Also required by: concurrent/ivar)
              concurrent/atomic/event: 0.6094 MiB (Also required by: concurrent/executor/immediate_executor, concurrent/atomics, and 3 others)
                concurrent/synchronization: 0.5703 MiB (Also required by: concurrent/executor/abstract_executor_service, concurrent/utility/at_exit, and 29 others)
        concurrent/atomics: 0.7422 MiB (Also required by: concurrent/executor/simple_executor_service)

@bschaeffer
Copy link
Contributor Author

bschaeffer commented Sep 12, 2017

Not sure why coverage dropped 4%... removed 15 lines should have gone up.

Copy link
Collaborator

@tfausak tfausak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@tfausak tfausak merged commit 5785642 into bolshakov:master Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants