Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extra plugin for Ckeditor #5342

Closed
wants to merge 1 commit into from
Closed

Allow extra plugin for Ckeditor #5342

wants to merge 1 commit into from

Conversation

WedgeSama
Copy link
Contributor

For now, the config.extraPlugin of Ckeditor is set during the initcke without taking the default value.
The PR just check if there is a value in config.extraPlugin and if it does, it will not be ignore.

This allow you to set the default global CKEDITOR.config.extraPlugin without loosing it. (for example to add table advanced plugin).

If necessary, I can PR for 3.0 too.

@bobdenotter
Copy link
Member

Will this change mean you can add extra CKeditor plugins via config.yml? If so, could you update config.yml.dist to say so?

If necessary, I can PR for 3.0 too.

Yes please. Bolt 2.2 is in "bugfix only mode". This means we're not adding new features to Bolt 2.2.x anymore.

@SvanteRichter
Copy link
Contributor

Also, perhaps some docs besides the config.yml.dist comment/key would be nice.

@GwendolenLynch
Copy link
Contributor

@SahAssar assigning you as sponsor for this.

@WedgeSama as mentioned above, 2.2 is in bug fix mode, so we're going to re-target this against current master (which will land soon in 3.1).

Over to you, @SahAssar 😉

@SvanteRichter
Copy link
Contributor

SvanteRichter commented Jul 13, 2016

@WedgeSama If you could retarget this to master it would be awesome, after it is merged (and we have some docs for it) we/I can tinker with getting a hook for extensions to be able to add ckeditor plugins too :)

@GwendolenLynch
Copy link
Contributor

Merged into master via c4a2efe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants