[3.3] [Deprecations] Switch YamlUpdater to use Bolt filesystem for YAML handling #6557
Conversation
|
Side note: $ ./app/nut config:get thumbnails/aliases/myimageformat/cropping -f theme://theme.yml
thumbnails/aliases/myimageformat/cropping: crop |
src/Configuration/YamlUpdater.php
Outdated
| $this->parsed = $this->parser->parse($yaml, true, true); | ||
| if (is_string($file)) { | ||
| $fs = $app['filesystem']->getFilesystem('config'); | ||
| $file = $fs->getFile($file); |
There was a problem hiding this comment.
Why not:
$file = $app['filesystem']->getFile('config://' . $file);There was a problem hiding this comment.
Throw … exception
src/Configuration/YamlUpdater.php
Outdated
| @@ -156,7 +149,7 @@ protected function verify() | |||
| } | |||
|
|
|||
| // This will throw a ParseException If the YAML is not valid | |||
| $this->parser->parse($this->yaml, true, true); | |||
| $this->parsed = $this->file->parse(['exceptionsOnInvalidType' => true, 'objectSupport' => true]); | |||
There was a problem hiding this comment.
This won't work as the file doesn't have the new contents yet.
Yeah, I did wonder … I might in the morning |
Done |
|
This should be GTG now, right? |
/me nudges @CarsonF |
src/Configuration/YamlUpdater.php
Outdated
| { | ||
| $pattern = str_replace('/', ':.*?', $key); | ||
| preg_match_all('/^' . $pattern . '(:\s*)/mis', $this->file->read(), $matches, PREG_OFFSET_CAPTURE); | ||
| preg_match_all('/^' . $pattern . '(:\s*)/mis', $this->lines->join("\n"), $matches, PREG_OFFSET_CAPTURE); |
There was a problem hiding this comment.
Expected 1 space after comma in function call; 2 found
src/Configuration/YamlUpdater.php
Outdated
| $yaml = $this->lines->join("\n"); | ||
|
|
||
| $pattern = '/^' . str_replace('/', ':.*?', $key) . '(:\s*)/mis'; | ||
| preg_match($pattern, $yaml, $matches, PREG_OFFSET_CAPTURE); |
There was a problem hiding this comment.
Expected 1 space after comma in function call; 2 found
Cuts out deprecations in SF 3.1+ too