Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.3] Fixes for .bolt.yml / .bolt.php custom path handling #6805

Merged
merged 4 commits into from
Jul 12, 2017
Merged

[3.3] Fixes for .bolt.yml / .bolt.php custom path handling #6805

merged 4 commits into from
Jul 12, 2017

Conversation

GwendolenLynch
Copy link
Contributor

@GwendolenLynch GwendolenLynch commented Jul 10, 2017

Fixes #6797

OK, so this was a bit of fun to debug with a brain that is only coming back into business mode … not to mention keeping backward and forward compatibility working. 🤣

This PR addresses the first problem I hit with BootstrapYamlUpdater updating custom path handling:

  • Add forward-compatible path resolution for var/ (it's in active use in the wild on 3.2+ sites)
  • Handle FC path updating for use of var/
  • Don't assume that a path that defaults to being under app/ is actually under app/
  • Adds a note on debugging Composer for ageing princesses with memory recall problems 😜

Bolt 3.2.x use/test case, taken from a production site:

paths:
    var: var
    cache: var/cache
    config: app/config
    database: app/database
    web: web
    themebase: web/theme
    files: web/files
    view: web/bolt-web/view

@GwendolenLynch GwendolenLynch added this to the Bolt 3.3 - Feature release milestone Jul 10, 2017
Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a bunch of monkey-testing, works fine for me. 🐵

@GwendolenLynch
Copy link
Contributor Author

Reviewed and approved by @bobdenotter and in-principle agreement at last night's meeting from @CarsonF … so sending in for today's march toward 3.3.

@GwendolenLynch GwendolenLynch merged commit af9d762 into bolt:release/3.3 Jul 12, 2017
@GwendolenLynch GwendolenLynch deleted the hotfix/yaml-updater branch July 12, 2017 05:26
michaelborn pushed a commit to michaelborn/bolt that referenced this pull request Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants