Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/set default #1362

Merged
merged 14 commits into from
May 12, 2020
Merged

Feature/set default #1362

merged 14 commits into from
May 12, 2020

Conversation

I-Valchev
Copy link
Member

@I-Valchev I-Valchev commented May 8, 2020 •
edited
Loading

Refactors sets similar to collections.

For some reason, email field being 'generic' broke collections 🤷‍♂️
Other generic fields seem to work...

@I-Valchev I-Valchev force-pushed the feature/set-default branch from 94e0da7 to e360c87 Compare May 11, 2020 10:50
@I-Valchev I-Valchev mentioned this pull request May 11, 2020
Closed
@I-Valchev I-Valchev changed the title [WIP] Feature/set default Feature/set default May 12, 2020
bobdenotter
bobdenotter approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bobdenotter bobdenotter merged commit b8820ed into master May 12, 2020
@bobdenotter bobdenotter deleted the feature/set-default branch May 12, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobdenotter bobdenotter bobdenotter approved these changes

Assignees
No one assigned
Labels
🐛 tag: bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@I-Valchev @bobdenotter