Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix htmllang() when no locales defined #1439

Merged
merged 2 commits into from
Jun 5, 2020
Merged

Fix htmllang() when no locales defined #1439

merged 2 commits into from
Jun 5, 2020

Conversation

I-Valchev
Copy link
Member

@I-Valchev I-Valchev commented Jun 3, 2020 •
edited
Loading

Fixes htmllang part of #1437

@bobdenotter bobdenotter merged commit b38d9ba into master Jun 5, 2020
@bobdenotter bobdenotter deleted the bugfix/htmllang-default-locale branch June 5, 2020 10:20
@milosa
Copy link

milosa commented Jun 8, 2020

My htmllang() is still empty in RC 23.

@milosa milosa mentioned this pull request Jun 9, 2020
Closed
@bobdenotter
Copy link
Member

@milosa Does that install have bobdenotter/configuration-notices ? ;-)

@milosa
Copy link

milosa commented Jun 9, 2020

@bobdenotter Yes, it does. I tried it on a clean install.

@peterboorsma
Copy link
Contributor

I can confirm @milosa 's findings.
The {{htmllang()}} tag remains empty in RC23. In my case only on a site with 1 language and no locales in contenttypes.yaml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobdenotter bobdenotter bobdenotter approved these changes

Assignees
No one assigned
Labels
🐛 tag: bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@I-Valchev @milosa @bobdenotter @peterboorsma