Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add defaultlocale to duplicate action twig #1569

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Add defaultlocale to duplicate action twig #1569

merged 1 commit into from
Jun 29, 2020

Conversation

I-Valchev
Copy link
Member

Fixes #1566

bobdenotter
bobdenotter approved these changes Jun 29, 2020
View reviewed changes
Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.. If we're going to be using defaultlocale in more places in the future, we might consider moving it to TwigAwareController.

@bobdenotter bobdenotter merged commit f7f2729 into master Jun 29, 2020
@bobdenotter bobdenotter deleted the bugfix/duplicate-has-default-locale branch June 29, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobdenotter bobdenotter bobdenotter approved these changes

Assignees
No one assigned
Labels
🐛 tag: bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Variable "defaultlocale" does not exist on duplicate
2 participants
@I-Valchev @bobdenotter