Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow order by number field correctly #1616

Merged
merged 3 commits into from
Jul 10, 2020
Merged

Allow order by number field correctly #1616

merged 3 commits into from
Jul 10, 2020

Conversation

I-Valchev
Copy link
Member

@I-Valchev I-Valchev commented Jul 7, 2020 •
edited
Loading

Fixes #1356

Order by number field now casts the field value to int, so that the order by operates on numeric values.

bobdenotter
bobdenotter approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some coercion PHPStan isn't compaining anymore. 👍

@bobdenotter bobdenotter merged commit 2070d8f into master Jul 10, 2020
@bobdenotter bobdenotter deleted the bugfix/order-by-number-field branch July 10, 2020 12:09
@bobdenotter bobdenotter changed the title Order by number field Order by number field Jul 11, 2020
@bobdenotter bobdenotter changed the title Order by number field Allow order by number field correctly Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobdenotter bobdenotter bobdenotter approved these changes

Assignees
No one assigned
Labels
🐛 tag: bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setcontent order by integer doesn't sort properly
2 participants
@I-Valchev @bobdenotter