Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Child fields can render html by default, without |raw filter #1673

Merged
merged 2 commits into from
Aug 3, 2020

Conversation

I-Valchev
Copy link
Member

Fixes #1558

return $value[$key];
$value = $value[$key];

return $value instanceof self ? $value->getTwigValue() : $value;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line could do with a comment, i think. I see what it does, but why does it do this?

Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice! 👍

@bobdenotter bobdenotter merged commit 80f4bc6 into master Aug 3, 2020
@bobdenotter bobdenotter deleted the bugfix/render-html-of-child-fields branch August 3, 2020 12:11
@bobdenotter bobdenotter changed the title Child fields can render html by default, without |raw filter Child fields can render html by default, without |raw filter Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTML field not parsed when inside set/collection
2 participants