Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove max-width from prefix and postfix #1796

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Remove max-width from prefix and postfix #1796

merged 1 commit into from
Sep 1, 2020

Conversation

eduardomart
Copy link
Contributor

max-width was keeping pre and postfix from using 100% of the width of its container

@eduardomart
Remove max-width
dcf7f70 
max-width was keeping pre and postfix from using 100% of the width of its container
@eduardomart
Copy link
Contributor Author

As evertalbers mentioned on Slack, maybe this is something to consider before merging...

From a legibility perspective there is something to be said for a max width of plm. 60-70 chars which may be around 46 em.

@bobdenotter bobdenotter merged commit 8e7d2d9 into bolt:master Sep 1, 2020
@bobdenotter
Copy link
Member

bobdenotter commented Sep 1, 2020 •
edited
Loading

@eduardomart Too late, merged already ;-)

@bobdenotter bobdenotter mentioned this pull request Sep 2, 2020
Merged
@bobdenotter bobdenotter changed the title Remove max-width Remove max-width Sep 2, 2020
@bobdenotter bobdenotter changed the title Remove max-width Remove max-width from prefix and postfix Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobdenotter bobdenotter bobdenotter approved these changes

Assignees
No one assigned
Labels
tag: enhancement topic: UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eduardomart @bobdenotter @I-Valchev