Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow src in iframes for embeds to work. Add spinner feedback while embed is loading. #1820

Merged
merged 1 commit into from
Sep 3, 2020
Merged

Allow src in iframes for embeds to work. Add spinner feedback while embed is loading. #1820

merged 1 commit into from
Sep 3, 2020

Conversation

I-Valchev
Copy link
Member

Fixes #1788
Fixes #1787

bobdenotter
bobdenotter approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! 👍

@bobdenotter bobdenotter merged commit 3f0498d into master Sep 3, 2020
@bobdenotter bobdenotter deleted the bugfix/embed-src-and-feedback branch September 3, 2020 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobdenotter bobdenotter bobdenotter approved these changes

Assignees
No one assigned
Labels
🐛 tag: bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Embeds sometimes won't show Embed does _NOT_ give any feedback while preview is fetching
2 participants
@I-Valchev @bobdenotter