Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Move PHPStan and Composer Validate from Travis to Github Actions #1916

Merged
merged 2 commits into from
Sep 28, 2020
Merged

[CI] Move PHPStan and Composer Validate from Travis to Github Actions #1916

merged 2 commits into from
Sep 28, 2020

Conversation

TomasVotruba
Copy link
Contributor

@TomasVotruba TomasVotruba commented Sep 28, 2020 •
edited
Loading

Follow up to #1912

TomasVotruba
TomasVotruba commented Sep 28, 2020
View reviewed changes
phpstan.neon
Comment on lines +4 to +7

paths:
- src

Copy link
Contributor Author

@TomasVotruba TomasVotruba Sep 28, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's best practise to have paths in configs, because it's now impossible to forget them. They're always used :)

@TomasVotruba
Copy link
Contributor Author

Ready to merge ✔️

@TomasVotruba TomasVotruba mentioned this pull request Sep 28, 2020
Merged
bobdenotter
bobdenotter approved these changes Sep 28, 2020
View reviewed changes
Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @TomasVotruba 👍

Merging this one and #1917 in!

@bobdenotter bobdenotter merged commit 3ed6837 into bolt:master Sep 28, 2020
@TomasVotruba TomasVotruba deleted the github-actions-phpstan branch September 28, 2020 14:34
@bobdenotter bobdenotter added the topic: DX Improving code quality, tests coverage, making codebase more intuitive label Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobdenotter bobdenotter bobdenotter approved these changes

Assignees
No one assigned
Labels
topic: DX Improving code quality, tests coverage, making codebase more intuitive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomasVotruba @bobdenotter