Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Don't break when passing in params for "Search Query" #1922

Merged
merged 4 commits into from
Sep 30, 2020

Conversation

bobdenotter
Copy link
Member

No description provided.

Copy link
Member

@I-Valchev I-Valchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bobdenotter I wonder if this will break it if you'd like to seach for something that is empty?

@bobdenotter
Copy link
Member Author

I think we need to differentiate between two types of "breaking" here:

  1. Malformed input causing Bolt to show an error page (which it should never do)
  2. Malformed input causing incorrect results (which is unavoidable, because we don't control what's being input)

This PR fixes one two instances of the former, where I managed to get an exception screen.

I did some monkey-testing on searching for non-existing Fieldnames and the like. Searching for 'empty' values treats it like that parameter isn't there, so I think that's OK.

@I-Valchev I-Valchev self-requested a review September 30, 2020 07:05
Copy link
Member

@I-Valchev I-Valchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bobdenotter right I see! Let's roll with this 👍

@I-Valchev I-Valchev merged commit e3c4abc into master Sep 30, 2020
@I-Valchev I-Valchev deleted the fix/dont-break-when-passing-in-arrays branch September 30, 2020 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants