Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add stylelint 4 space indent #1967

Merged
merged 5 commits into from
Oct 12, 2020

Conversation

TomasVotruba
Copy link
Contributor

@TomasVotruba TomasVotruba commented Oct 8, 2020

Follow up to #1966 - merge it first

Just space shift due to .editorconfig update.
#til It's nice that npm style lint adapts to it :)

@TomasVotruba TomasVotruba changed the title tv ci stylelint indent [CI] Add stylelint 4 space indent Oct 8, 2020
@@ -4,7 +4,5 @@ root = true
; Unix-style newlines
[*]
end_of_line = LF

[*.php]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's seem this file haven't been serving its purpose before.
This allows to have standard 4-space format for each file.

Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's quite common in projects that are mainly JS to use 2-space indents, but I think it makes sense here to use 4-space for everything. We already do so for PHP and Twig, anyways!

Let's roll with this! 👍

bobdenotter
bobdenotter approved these changes Oct 12, 2020
@bobdenotter bobdenotter merged commit ebff688 into bolt:master Oct 12, 2020
@TomasVotruba TomasVotruba deleted the tv-ci-stylelint-indent branch October 12, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants