Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add .gitattributes file for release #1980

Merged
merged 1 commit into from
Oct 12, 2020
Merged

Feat: add .gitattributes file for release #1980

merged 1 commit into from
Oct 12, 2020

Conversation

toofff
Copy link
Contributor

@toofff toofff commented Oct 11, 2020

When creating an archive we may not take certain files or folders into account.

Here is an example of what we could gain in weight in the vendors of the project:

  • bolt-core-4.1.0.tar.gz => 3,1 Mo
  • bolt-core-my-test.tar.gz => 334 Ko

By removing all the files that are not necessary for the core to work in a project vendor, we reduce the package by 90% of its weight.
This is not negligible for a production release and to avoid overloading server resources for nothing.

@toofff toofff marked this pull request as ready for review October 12, 2020 11:36
@bobdenotter
Copy link
Member

@toofff Cool stuff.

I'm getting questions occasionally from people who still have trouble using Composer, saying they'd prefer a simple .zip distro. Is the technique in this PR something that might be applicable to bolt/project as well, so we could potentially make a lighter .zip distro for these people?

@bobdenotter bobdenotter merged commit 57c5322 into bolt:master Oct 12, 2020
@toofff toofff deleted the feature/add-gitattributes-file branch October 12, 2020 13:33
@toofff
Copy link
Contributor Author

toofff commented Oct 12, 2020

@bobdenotter in my PR on "bolt/project" I didn't put it because I didn't need it. But I'll still check and get back to you this week.

@bobdenotter bobdenotter changed the title Feat: add .gitattributes file for release Feat: add .gitattributes file for release Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants