Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing of theme.yml #2059

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Fix parsing of theme.yml #2059

merged 1 commit into from
Oct 26, 2020

Conversation

artggd
Copy link
Contributor

@artggd artggd commented Oct 25, 2020

Hello 👋

When using custom public_dir folder, the config fails to parse the theme.yaml because the PathResolver is constructed with the default $publicFolder : "public"

I propose a fix by passing $publicFolder to PathResolver's constructor .

bobdenotter
bobdenotter approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thank you, @artggd 👍

@bobdenotter
Copy link
Member

Merging into 4.1 as well as master!

@bobdenotter bobdenotter merged commit b62fc2d into bolt:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobdenotter bobdenotter bobdenotter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artggd @bobdenotter