Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix incorrect |current filter for localized menu items #2118

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Bugfix incorrect |current filter for localized menu items #2118

merged 1 commit into from
Nov 10, 2020

Conversation

I-Valchev
Copy link
Member

@I-Valchev I-Valchev commented Nov 10, 2020 •
edited
Loading

Fixes issue with localized menu URI's not recognised as current. Credits to @nestordedios for finding and debugging this!

Also fixes issue with using record.slug. It used to return the wrong locale.

bobdenotter
bobdenotter approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @I-Valchev and @nestordedios

@bobdenotter bobdenotter merged commit 577f5b9 into master Nov 10, 2020
@bobdenotter bobdenotter deleted the bugfix/current-menu-locale branch November 10, 2020 12:32
@bobdenotter
Copy link
Member

I have cherry-picked this into 4.1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobdenotter bobdenotter bobdenotter approved these changes

Assignees
No one assigned
Labels
🐛 tag: bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@I-Valchev @bobdenotter