Fix casting exception with orderby when using MySQL/PostgreSQL
#2290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobdenotter
requested changes
Jan 7, 2021
| @@ -116,6 +116,8 @@ private function setOrderBy(QueryInterface $query, string $order, string $direct | |||
| // Note the `lower()` in the `addOrderBy()`. It is essential to sorting the | |||
| // results correctly. See also https://github.com/bolt/core/issues/1190 | |||
| // again: lower breaks postgresql jsonb compatibility, first cast as txt | |||
| // cast as TEXT or CHAR, depending on SQL support. See Bolt\Doctrine\Query\Cast.php | |||
| // and https://github.com/bolt/core/issues/2241 | |||
| $query | |||
| ->getQueryBuilder() | |||
| ->addOrderBy('lower(CAST(' . $translationsAlias . '.value as TEXT))', $direction); | |||
There was a problem hiding this comment.
Shouldn't this TEXT also be dependent on the platform, then?
There was a problem hiding this comment.
(As explained by Ivo: No, it shouldn't)
bobdenotter
approved these changes
Jan 7, 2021
bobdenotter
changed the title
orderby when using MySQL/PostgreSQLorderby when using MySQL/PostgreSQL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2241