Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more specific selector for the setcontent [no] test page #2418

Merged
merged 3 commits into from
Feb 24, 2021

Conversation

I-Valchev
Copy link
Member

Turns out that a lot of the times there's dumps in the Symfony debug toolbar that contain the [no] from the Twig template, which tricks the tests to assume there's an error.

Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6d8956db30a984d9b964020f26315c5e

@bobdenotter bobdenotter merged commit b2272e7 into 4.1 Feb 24, 2021
@bobdenotter bobdenotter deleted the tests/specific-setcontent-test-selector branch February 24, 2021 10:44
@I-Valchev
Copy link
Member Author

@bobdenotter "Behat says no" 🤡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants