Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set correct classes and disabled states for the _pager_basic.html.twig pager #2460

Merged
merged 6 commits into from
Mar 13, 2021
Merged

Set correct classes and disabled states for the _pager_basic.html.twig pager #2460

merged 6 commits into from
Mar 13, 2021

Conversation

I-Valchev
Copy link
Member

Fixes #2457

@I-Valchev I-Valchev changed the base branch from 4.1 to 4.2 March 10, 2021 12:43
@I-Valchev I-Valchev changed the base branch from 4.2 to 4.1 March 10, 2021 12:43
bobdenotter
bobdenotter approved these changes Mar 13, 2021
View reviewed changes
Copy link
Member

@bobdenotter bobdenotter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After adding a well-placed is defined, tests are now passing! 👍

@bobdenotter bobdenotter merged commit e07a09b into 4.1 Mar 13, 2021
@bobdenotter bobdenotter deleted the bugfix/basic-pager-sane-html branch March 13, 2021 12:48
@I-Valchev
Copy link
Member Author

Ah! Cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobdenotter bobdenotter bobdenotter approved these changes

Assignees
No one assigned
Labels
🐛 tag: bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Basic pager renders incorrect html
2 participants
@I-Valchev @bobdenotter