Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin Chromedriver to version 90.x #2610

Merged
merged 3 commits into from
Jun 4, 2021
Merged

Pin Chromedriver to version 90.x #2610

merged 3 commits into from
Jun 4, 2021

Conversation

bobdenotter
Copy link
Member

We pin Chromedriver to 90.something, because 91 appends text when using .setValue() instead of replacing it.

nestordedios
nestordedios approved these changes Jun 4, 2021
View reviewed changes
Copy link
Collaborator

@nestordedios nestordedios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

I-Valchev
I-Valchev approved these changes Jun 4, 2021
View reviewed changes
Copy link
Member

@I-Valchev I-Valchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Let's hope it gets fixed soon!

@I-Valchev I-Valchev merged commit 92ccf9f into 4.1 Jun 4, 2021
@I-Valchev I-Valchev deleted the fix/pin-chromedriver branch June 4, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@I-Valchev I-Valchev I-Valchev approved these changes

@nestordedios nestordedios nestordedios approved these changes

Assignees
No one assigned
Labels
🐛 tag: bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bobdenotter @nestordedios @I-Valchev