Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error in custom code producing seemingly unrelated message. Catch LoaderLoadException instead of Throwable #2623

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Fix error in custom code producing seemingly unrelated message. Catch LoaderLoadException instead of Throwable #2623

merged 1 commit into from
Jun 11, 2021

Conversation

bobdenotter
Copy link
Member

@bobdenotter bobdenotter commented Jun 11, 2021 •
edited
Loading

Fixes #2622
Fixes #2586

I-Valchev
I-Valchev approved these changes Jun 11, 2021
View reviewed changes
Copy link
Member

@I-Valchev I-Valchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice fix! FINALLY 🥳

@mcdennem mcdennem self-requested a review June 11, 2021 13:33
mcdennem
mcdennem approved these changes Jun 11, 2021
View reviewed changes
Copy link
Member

@mcdennem mcdennem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@mcdennem mcdennem merged commit f818ee3 into 4.1 Jun 11, 2021
@mcdennem mcdennem deleted the fix/kernel branch June 11, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdennem mcdennem mcdennem approved these changes

@I-Valchev I-Valchev I-Valchev approved these changes

Assignees
No one assigned
Labels
🐛 tag: bug fix
Projects
None yet
Milestone
No milestone
3 participants
@bobdenotter @I-Valchev @mcdennem