Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search now also finds words with special characters, like büßen #2767

Merged
merged 1 commit into from
Aug 13, 2021
Merged

Search now also finds words with special characters, like büßen #2767

merged 1 commit into from
Aug 13, 2021

Conversation

bobdenotter
Copy link
Member

Fixes #2758

afbeelding

mcdennem
mcdennem approved these changes Aug 13, 2021
View reviewed changes
Copy link
Member

@mcdennem mcdennem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@bobdenotter bobdenotter merged commit dfa5e9e into 4.2 Aug 13, 2021
@bobdenotter bobdenotter deleted the fix/search-unicode-characters branch August 13, 2021 07:32
@eherber
Copy link

eherber commented Aug 14, 2021

Hi Bob,

thank you for fixing this bug.

I already tested the fix and it works fine, german special characters could now be used in the search query string
and results are found.

Thank you.

-Eric

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdennem mcdennem mcdennem approved these changes

Assignees
No one assigned
Labels
🐛 tag: bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search for strings containing german special characters (Umlaute)
3 participants
@bobdenotter @eherber @mcdennem