Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow labels to be edited in the Editor #2865

Merged
merged 4 commits into from
Oct 22, 2021
Merged

Allow labels to be edited in the Editor #2865

merged 4 commits into from
Oct 22, 2021

Conversation

I-Valchev
Copy link
Member

@I-Valchev I-Valchev commented Oct 18, 2021 •
edited
Loading

Linked with bolt/project#95

Todo:

  • Add yaml migration
  • Decide if all locales or only used locales should be available

@bobdenotter bobdenotter marked this pull request as draft October 19, 2021 14:21
@I-Valchev I-Valchev marked this pull request as ready for review October 21, 2021 12:50
bobdenotter
bobdenotter approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bobdenotter
Copy link
Member

I tweaked the migration.. That entire block is missing from 'project'

@I-Valchev
Copy link
Member Author

Aha, good catch @bobdenotter , thanks!

@bobdenotter bobdenotter merged commit ea7beac into master Oct 22, 2021
@bobdenotter bobdenotter deleted the bugfix/edit-locales-in-editor branch October 22, 2021 07:39
@bobdenotter bobdenotter added topic: Multilingual 🌐 Language, i10n, i18n, translations 🐛 tag: bug fix labels Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobdenotter bobdenotter bobdenotter approved these changes

Assignees
No one assigned
Labels
🐛 tag: bug fix topic: Multilingual 🌐 Language, i10n, i18n, translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@I-Valchev @bobdenotter