Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow symfony/flex v2 #2984

Merged
merged 2 commits into from
Nov 29, 2021
Merged

Allow symfony/flex v2 #2984

merged 2 commits into from
Nov 29, 2021

Conversation

bobvandevijver
Copy link
Contributor

Symfony/flex v2 should be compatible with Bolt, so lets allow it. See https://github.com/symfony/flex/releases/tag/v2.0.0 for the release notes, it is basically a versions which only support composer 2.1+ & PHP 8.0+.

Symfony/flex v2 should be compatible with Bolt, so lets allow it. See https://github.com/symfony/flex/releases/tag/v2.0.0 for the release notes, it is basically a versions which only support composer 2.1+ & PHP 8.0+.
composer.json Outdated Show resolved Hide resolved
@bobvandevijver
Copy link
Contributor Author

Don't know why the test fail for this change though..

Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to @Joossensei, it's failing due to an error in Cypress, that's already fixed in master. (#2968, iirc)

So, let's merge this one in! :shipit:

@bobdenotter bobdenotter merged commit f027a55 into bolt:master Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants