Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date issues in Bolt 5 #2986

Merged
merged 4 commits into from
Dec 3, 2021
Merged

Date issues in Bolt 5 #2986

merged 4 commits into from
Dec 3, 2021

Conversation

Joossensei
Copy link
Contributor

@Joossensei Joossensei commented Nov 29, 2021 •
edited
Loading

This (#2993) bug has a bunch of things that nee to be done:

  • Find out where the data gets saved as Zulu
  • Change this to the normal Y-m-d h:i format
  • See if date filtering works with a 'between' query ( ' >= date ' & ' <= date' )

Fixes #2993

Joossensei and others added 3 commits November 29, 2021 14:55
@Joossensei
Fix the format and fix typo
c5fcfc3
@Joossensei
Fix Ivo's suggestion :D
d8407f4
@Joossensei
Revert changes back
c81207e 
The database doesnt store date field values as Zulu therefore this was not actually needed
@Joossensei Joossensei changed the title Fix the format and fix typo Revert changes to date parsing Dec 1, 2021
@Joossensei Joossensei changed the title Revert changes to date parsing [WIP] Possible date issues in Bolt 5? Dec 2, 2021
@Joossensei Joossensei marked this pull request as draft December 2, 2021 09:44
@Joossensei
Copy link
Contributor Author

Screenshot 2021-12-03 at 10 35 26

New format they are saved in

@Joossensei Joossensei marked this pull request as ready for review December 3, 2021 09:36
@Joossensei Joossensei changed the title [WIP] Possible date issues in Bolt 5? Date issues in Bolt 5 Dec 3, 2021
nestordedios
nestordedios approved these changes Dec 3, 2021
View reviewed changes
Copy link
Collaborator

@nestordedios nestordedios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @Joossensei!! It looks good! 👍

@nestordedios
Copy link
Collaborator

@Joossensei as showed in your screenshot... Does the new format also allow for strings like "dummie-2"? I don't think that is really what we would want.

@Joossensei
Copy link
Contributor Author

Joossensei commented Dec 3, 2021 •
edited
Loading

@nestordedios that is the slug! It isnt a date field😅

bobdenotter
bobdenotter approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I-Valchev
I-Valchev approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@I-Valchev I-Valchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Let's roll with it!

@I-Valchev I-Valchev merged commit 42fedf2 into master Dec 3, 2021
@I-Valchev I-Valchev deleted the bugfix/make-date-actually-work branch December 3, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@I-Valchev I-Valchev I-Valchev approved these changes

@nestordedios nestordedios nestordedios approved these changes

@bobdenotter bobdenotter bobdenotter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Date formats are stored differently in a database
4 participants
@Joossensei @nestordedios @bobdenotter @I-Valchev