Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more diacritics to transliteration. #3038

Closed
wants to merge 2 commits into from
Closed

Add more diacritics to transliteration. #3038

wants to merge 2 commits into from

Conversation

vlad-ghita
Copy link
Contributor

Support some diacritics: ă, ș, ț, Ă, Ș, Ț.

@vlad-ghita
Copy link
Contributor Author

@bobdenotter

Any ETA to merge and publish this PR?

It's really important for Romanian language (think about all slugs).

input    : noutăți
before PR: nout-i
after PR : noutati

Thanks!

@bobdenotter
Copy link
Member

Hi @vlad-ghita ,

I can't merge this in yet, because the tests are failing. I'm not sure why yet. Maybe because of some external cause, or maybe because you changed composer.lock and composer.json. I'll have to look into it.

@bobdenotter bobdenotter mentioned this pull request Jan 9, 2022
Merged
@bobdenotter
Copy link
Member

Closing this one, because the change is merged in #3043

thanks again, @vlad-ghita 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlad-ghita @bobdenotter