Update float field so it uses step='any' by default
#3122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way you don't have a fixed amount of numbers after the comma
Joossensei
changed the title
bobdenotter
changed the title
step='any' by default
dadaxr
added a commit
to dadaxr/core
that referenced
this pull request
Mar 28, 2022
since v5.1.5, commit bolt#3122 when number field "mode" is "float" (which is by default), the step is "'any'" by default (note the single quote wrapped by the double quote). This "'any'" value should not be escaped because it breaks when the number field is used within a collection. For instance, bellow is an extract of an "editor-collection" component generated by the backend when using a collection field having "number" field as child, we can see it use a :template prop filled with escaped templates of fields members : ``` <editor-collection :existing-fields='[]' :templates='[{ .. <editor-number ... value=\"\"\n :step=\"&bolt#39;any&bolt#39;\"\n ...' :labels='...' :limit='200' :name=""gallery_slider_images"" :variant=""collapsed"" ></editor-collection> ``` Without applying a |raw filter, the value is double encoded and generates : `:step=\"&bolt#39;any&bolt#39;\"` (which decoded is the same as `:step=\"&bolt#39;any&bolt#39;\"` instead of `:step=\"&bolt#39;any&bolt#39;\"` (which decoded is the same as `:step=\"'any'\"`) This leads to a vue compilation error : ``` [Vue warn]: Error compiling template: ... <editor-number :id='"field-gallery_slider_images-slider_image_set-6241de74820e3-coord_y"' name="collections[gallery_slider_images][slider_image_set][6241de74820e3][coord_y]" value="" :step="&bolt#39;any&bolt#39;" :required="false" :readonly="false" :errormessage="false" :pattern="false" :placeholder="""" ></editor-number> ... - invalid expression: expected expression, got '&' in &bolt#39;any&bolt#39; Raw expression: :step="&bolt#39;any&bolt#39;" ``` However when using number field directly (ie without a collection field) it's was working. Using the |raw filter makes it work in both cases. Note : this regression can lead to data loss when saving broken collections ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way the amount of decimals after the comma isn't fixed by default