Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional fix for type: number field, set default to min: 0. #3252

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Additional fix for type: number field, set default to min: 0. #3252

merged 1 commit into from
Jun 21, 2022

Conversation

bobdenotter
Copy link
Member

See also #3231

@bobdenotter bobdenotter requested a review from xiaohutai June 21, 2022 13:22
xiaohutai
xiaohutai approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@xiaohutai xiaohutai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one. I took over the min and max values that were placed there. Technically 1000 may be too low of a value too, right?

@xiaohutai xiaohutai merged commit 7b8d36f into master Jun 21, 2022
@xiaohutai xiaohutai deleted the fix/min-zero branch June 21, 2022 14:18
@bobdenotter
Copy link
Member Author

The issue with 1 was that it's the default value of the field is 0, so just putting in the filed would block you from posting, which was confusing. :-)

bobdenotter added a commit that referenced this pull request Jul 5, 2022
@bobdenotter
Cherry-pick #3252
4206f90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaohutai xiaohutai xiaohutai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobdenotter @xiaohutai