Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix phpstan errors #3395

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Conversation

enrise-mbraam
Copy link
Contributor

@enrise-mbraam enrise-mbraam commented Jan 24, 2023

Fix deprecation errors that appear when using Bolt on PHP 8.1 (and I guess 8.2)

Extending \Iterator is not needed, I believe.

Also fixed another error Phpstan reported in the same way it was dealt with in src/Controller/ErrorController.php

See image for errors that were occurring.

deprecation notices bolt

Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @enrise-mbraam. Looks good! 👍

@bobdenotter bobdenotter merged commit 7df316e into bolt:master Jan 27, 2023
bobdenotter added a commit that referenced this pull request Feb 3, 2023
Partial reverse of #3395, we really need those `\Iterator`s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants