Use Info::isValid() to verify src and/or error images instead of catch()

bolt · Jun 4, 2017 · 42b64ad · 42b64ad
1 parent 79f6d57
commit 42b64ad
Showing 1 changed file with 8 additions and 13 deletions.
diff --git a/src/Creator.php b/src/Creator.php
@@ -63,23 +63,18 @@ public function create(Transaction $transaction)
      */
     protected function verifyInfo(Transaction $transaction)
     {
-        try {
-            $transaction->getSrcImage()->getInfo();
-
+        if ($transaction->getSrcImage()->getInfo()->isValid()) {
             return;
-        } catch (IOException $e) {
         }
-
         $transaction->setSrcImage($transaction->getErrorImage());
-        try {
-            $transaction->getSrcImage()->getInfo();
-        } catch (IOException $e) {
-            throw new RuntimeException(
-                'There was an error with the thumbnail image requested and additionally the fallback image could not be displayed.',
-                1,
-                $e
-            );
+        if ($transaction->getSrcImage()->getInfo()->isValid()) {
+            return;
         }
+
+        throw new RuntimeException(
+            'There was an error with the thumbnail image requested and additionally the fallback image could not be displayed.',
+            1
+        );
     }
 
     /**