This repository has been archived by the owner on Mar 9, 2019. It is now read-only.
Wait for pending transactions on close #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the DB.Close() function so that it waits for any open transactions to finish before closing.
|
|
||
| db.mmaplock.RLock() | ||
| defer db.mmaplock.RUnlock() | ||
|
|
There was a problem hiding this comment.
This locking order is consistent with the rest of the library (rwlock, metalock, mmaplock). The mmaplock takes a read lock because the rwlock prevents the write lock on mmaplock.
benbjohnson
added a commit
that referenced
this pull request
May 21, 2015
Wait for pending transactions on close
rcoelho
added a commit
to rcoelho/bbolt
that referenced
this pull request
Feb 13, 2018
DB.Close() actually waits for the transactions to finish now, since the PR 377. boltdb/bolt#377
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request fixes the
DB.Close()function so that it waits for any open transactions to finish before closing.Previously a close would shutdown the
DBimmediately and cause a panic in any open transactions, however, no data corruption would occur.Fixes: #341