This repository has been archived by the owner on Mar 9, 2019. It is now read-only.
Release read-write Tx after close #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes references to the last write transaction and and its dirty pages after the transaction has been closed. This bug did not affect the safety of the data, however, it would cause dirty pages to linger in-memory until the next write transaction began.
|
/cc @pauldix |
| @@ -250,7 +251,12 @@ func (tx *Tx) close() { | |||
| } else { | |||
| tx.db.removeTx(tx) | |||
| } | |||
|
|
|||
| // Clear all references. | |||
There was a problem hiding this comment.
Could you put this stuff in a defer? Would it make sense? Perhaps the code is just clearer down here.
There was a problem hiding this comment.
The function doesn't have any other exit points. I'm not sure a defer would help.
benbjohnson
added a commit
that referenced
this pull request
Sep 4, 2015
Release read-write Tx after close
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request removes references to the last write transaction and and its dirty pages after the transaction has been closed. This bug did not affect the safety of the data, however, it would cause dirty pages to linger in-memory until the next write transaction began.