This repository has been archived by the owner on Mar 9, 2019. It is now read-only.
add WriteToFlag to Tx #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // | ||
| // If open file fails with the given flag, WriteTo will fail | ||
| // back to use empty flag. | ||
| WriteToFlag int |
There was a problem hiding this comment.
Can you change the name to WriteFlag? The interface is WriterTo but this flag would apply to other write methods if they were added later.
For in memory workload, it does not make sense to use o_direct to copy the file. Adding a option to clear out o_direct and for other future cases.
|
@benbjohnson All fixed. PTAL. |
|
👍 I made some doc changes and minor clean up in 6b1bbf0 as well. |
|
/cc @mkobetic This removes tx.WriteFlags = syscall.O_DIRECTbefore it calls to |
|
@benbjohnson Thank you! |
|
Thanks @benbjohnson, I made an issue to remind us when we update. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For in memory workload, it does not make sense to use
o_direct to copy the file. Adding a option to clear out
o_direct and for other future cases.