This repository has been archived by the owner on Mar 9, 2019. It is now read-only.
Introduce InitialMmapSize to prevent deadlock #472
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InitialMmapSize
is the initial mmap size of the database in bytes.Read transaction won't block write transaction if InitialMmapSize
is large enough to handle mmap size.
Copied from #432.
/cc @xiang90 @benbjohnson
I took this over from @xiang90 and confirmed that current implementation
easily causes deadlock when we pass 0 for
db.mmap
. You can simply reproduceas follows:
And it errors with deadlock:
etcd needs to set
InitialMmapSize
because long-running read transaction(e.g. snapshop transaction) should never block write transaction.