This repository has been archived by the owner on Mar 9, 2019. It is now read-only.
Set slice capacity #545
Merged
Set slice capacity #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -117,7 +118,9 @@ func (n *leafPageElement) key() []byte { | |||
| // value returns a byte slice of the node value. | |||
| func (n *leafPageElement) value() []byte { | |||
| buf := (*[maxAllocSize]byte)(unsafe.Pointer(n)) | |||
| return (*[maxAllocSize]byte)(unsafe.Pointer(&buf[n.pos+n.ksize]))[:n.vsize] | |||
| ret := (*[maxAllocSize]byte)(unsafe.Pointer(&buf[n.pos+n.ksize]))[:n.vsize] | |||
There was a problem hiding this comment.
Couldn't you just set the capacity by doing
ret := (*[maxAllocSize]byte)(unsafe.Pointer(&buf[n.pos+n.ksize]))[:n.vsize:n.vsize]instead of using reflect?
There was a problem hiding this comment.
I always forget about the third slice parameter. :)
Fixed in 2b4a0e2.
This commit sets the capacity on slices returned from `Bucket.Get()` to match the slice length. Previously the capacity would be the size of the mmap max size. This does not cause any backwards compatibility issues, however, it does allow users to `append()` to the returned slice since that will cause Go to realloc a new slice on the heap. Fixes boltdb#544
benbjohnson
force-pushed
the
slice-capacity
branch
from
04c02cc
to
2b4a0e2
Compare
|
@sasha-s I compared |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This commit sets the capacity on slices returned from
Bucket.Get()to match the slice length. Previously the capacity would be the size of the mmap max size.This does not cause any backwards compatibility issues, however, it does allow users to
append()to the returned slice since that will cause Go to realloc a new slice on the heap.Fixes #544
/cc @sasha-s