This repository has been archived by the owner on Mar 9, 2019. It is now read-only.
Delay clearing db.path until just before db.close returns. #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // defer clearing the path because funlock may need it. | ||
| defer func() { | ||
| db.path = "" | ||
| }() |
There was a problem hiding this comment.
Can you move this down to just before the return nil at the end of the function? I'd rather not have a defer if it's not necessary.
There was a problem hiding this comment.
Is it OK to leave the field populated if one of the error return paths is taken? What invariant is implied by setting db.path = ""?
There was a problem hiding this comment.
There's not an explicit guarantee about path when an error occurs. Honestly, I wish I hadn't reset the path at all on Close() but that's behavior now. I'm OK with changing the behavior on error to not clear the path.
The Windows version of funlock needs the db.path to delete the corresponding .lock file.
ChrisHines
force-pushed
the
windows-remove-lock
branch
from
2dc6c1c
to
5816124
Compare
|
@benbjohnson PR updated, PTAL. |
ChrisHines
changed the title
|
Thanks @ChrisHines! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows version of funlock needs the db.path to delete the
corresponding .lock file.
Fix for #549.