Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transport module to be public #366

Closed
marsella opened this issue Mar 2, 2022 · 2 comments
Closed

Update transport module to be public #366

marsella opened this issue Mar 2, 2022 · 2 comments
Assignees

Comments

@marsella
Copy link
Contributor

marsella commented Mar 2, 2022

We want to reuse the zeekoe transport module in the key-mgmt product, but it's currently private.

Easiest solution: make it a public module within zeekoe.
Another option: make it its own crate.

In either case, browse through the module before just making it public to be sure that the public interface is appropriately scoped.

@indomitableSwan
Copy link

I would advocate for modularity, i.e., splitting out any zeekoe logic we want to use into its own crate.

@gijsvl gijsvl self-assigned this Mar 25, 2022
gijsvl added a commit that referenced this issue Mar 25, 2022
gijsvl added a commit that referenced this issue Mar 25, 2022
gijsvl added a commit that referenced this issue Mar 25, 2022
gijsvl added a commit that referenced this issue Mar 25, 2022
gijsvl added a commit that referenced this issue Mar 31, 2022
gijsvl added a commit that referenced this issue Apr 20, 2022
gijsvl added a commit that referenced this issue Apr 20, 2022
gijsvl added a commit that referenced this issue Apr 20, 2022
gijsvl added a commit that referenced this issue Apr 20, 2022
gijsvl added a commit that referenced this issue Apr 20, 2022
gijsvl added a commit that referenced this issue Apr 20, 2022
@marsella
Copy link
Contributor Author

I think this is closed with #366 and the creation of the transport crate. Can re-open if we realize this isn't complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants